Skip to content

cmctl#728

Merged
jetstack-bot merged 5 commits intocert-manager:masterfrom
JoshVanL:cmctl-master
Oct 27, 2021
Merged

cmctl#728
jetstack-bot merged 5 commits intocert-manager:masterfrom
JoshVanL:cmctl-master

Conversation

@JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Oct 26, 2021

From #715

This PR adds a page for the new cmctl CLI. This page mostly replaces the existing kubectl-plugin page taking the same content but changing the commands and some wording.

The exiting kubectl-plugin page has been stripped down to just installing and linking to cmctl.

Users can still find all the docs they need, but moving the docs this way helps nudge users into using cmctl which has a better UX.

/assign @jakexks

@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Oct 26, 2021
@jetstack-bot
Copy link
Contributor

jetstack-bot commented Oct 26, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoshVanL

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2021
@netlify
Copy link

netlify bot commented Oct 26, 2021 •
edited
Loading

✔️ Deploy Preview for cert-manager-website ready!

🔨 Explore the source changes: 46972c9

🔍 Inspect the deploy log: https://app.netlify.com/sites/cert-manager-website/deploys/617974706c5af20008d1c3b4

😎 Browse the preview: https://deploy-preview-728--cert-manager-website.netlify.app/docs/installation/cmctl

@jetstack-bot jetstack-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 26, 2021
@jakexks jakexks mentioned this pull request Oct 27, 2021
Merged
@jakexks
Copy link
Member

jakexks commented Oct 27, 2021 

v1.5-docs/usage/certificate/index.html
  hash does not exist --- v1.5-docs/usage/certificate/index.html --> ../../../docs/usage/kubectl-plugin/#renew
  hash does not exist --- v1.5-docs/usage/certificate/index.html --> ../../../docs/usage/kubectl-plugin/#renew

Not sure if I missed any discussion in the large slack thread from yesterday, does this need still fixing in the release-1.5 branch?

/retest
/assign @JoshVanL

maelvls
maelvls reviewed Oct 27, 2021
View reviewed changes
Copy link
Member

@maelvls maelvls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. I left a couple of suggestions that aren't blocking.

@JoshVanL
Adds documentation for the new cmctl command.
99275e8 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Change faq reference to kubectl-plugin to cmctl
912e84d 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Adds redirects for 'kubectl cert-manager' headings to 'cmctl'
eb86fbe 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Adds style and grammar suggestions
744e487 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@JoshVanL
Copy link
Contributor Author

JoshVanL commented Oct 27, 2021

/retest

@JoshVanL
Fix spelling
46972c9 
Signed-off-by: joshvanl <vleeuwenjoshua@gmail.com>
@maelvls
Copy link
Member

maelvls commented Oct 27, 2021

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@jetstack-bot jetstack-bot merged commit 4116225 into cert-manager:master Oct 27, 2021
@jetstack-bot jetstack-bot mentioned this pull request Oct 27, 2021
Merged
@jetstack-bot jetstack-bot mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maelvls maelvls maelvls left review comments

Assignees

@jakexks jakexks

@maelvls maelvls

@JoshVanL JoshVanL

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoshVanL @jetstack-bot @jakexks @maelvls